Skip to content

chore: extract horizon and subgraph-service addresses to a new address-book package #1211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 30, 2025
Merged

chore: extract horizon and subgraph-service addresses to a new address-book package #1211

merged 1 commit into from
Jul 30, 2025

Conversation

Maikol
Copy link
Member

@Maikol Maikol commented Jul 28, 2025 •
edited
Loading

Description:
Resolves circular dependency between horizon, subgraph-service and toolshed packages by extracting
shared address book functionality into a new @graphprotocol/address-book package.

Changes:

  • Created @graphprotocol/address-book package with symlink-based development workflow
  • Updated toolshed to use address-book instead of horizon and subgraph-service
  • Added npm publishing scripts to handle symlink-to-file conversion
  • Fixed indexing disputes integration tests on the subgraph service

@Maikol Maikol requested review from pcarranzav and tmigone July 28, 2025 21:28
@codecov Codecov
Copy link

codecov bot commented Jul 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.84%. Comparing base (523d3b1) to head (4689fec).
⚠️ Report is 7 commits behind head on horizon.

Additional details and impacted files 
@@           Coverage Diff            @@
##           horizon    #1211   +/-   ##
========================================
  Coverage    82.84%   82.84%           
========================================
  Files           47       47           
  Lines         2093     2093           
  Branches       620      620           
========================================
  Hits          1734     1734           
  Misses         359      359
Flag Coverage Δ
unittests 82.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Maikol Maikol force-pushed the mde/address-book-package branch from 8534c3f to e718d7c Compare July 29, 2025 16:44
@Maikol Maikol force-pushed the mde/address-book-package branch from e718d7c to 4689fec Compare July 29, 2025 16:45
@Maikol Maikol merged commit ef8b05d into horizon Jul 30, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tmigone tmigone tmigone approved these changes

@pcarranzav pcarranzav Awaiting requested review from pcarranzav

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Maikol @tmigone